Calling .NET WebAssembly code from views #1526
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…tvvm into feature/csharp-client
exyi
reviewed
Dec 27, 2022
| throw new DotvvmCompilationException($"The type {type} referenced in the @dotnet directive must have exactly one public constructor with one parameter of IViewModuleContext!"); | ||
| } | ||
| // TODO: check parameter type | ||
| return Expression.New(constructors[0], Expression.Constant(null, typeof(object))) |
There was a problem hiding this comment.
Suggested change
| return Expression.New(constructors[0], Expression.Constant(null, typeof(object))) | |
| return Expression.New(constructors[0], Expression.Constant(null, typeof(IViewModuleContext))) |
It won't compile with object.
However, I'm thinking if we want to allow invoking the methods server-side. I guess it makes sense, but passing null into the constructor will just make it fail on the unexpected null reference. Maybe only allow it if the type also has parameterless constructor?
| this.imports = imports; | ||
| } | ||
|
|
||
| public override string DirectiveName => ParserConstants.CsharpViewModuleDirective; |
There was a problem hiding this comment.
You might want to rename CsharpViewModuleDirective to DotnetViewModuleDirective
| @@ -107,6 +107,7 @@ const dotvvmExports = { | |||
| call: viewModuleManager.callViewModuleCommand, | |||
| registerMany: viewModuleManager.registerViewModules | |||
| }, | |||
| get virtualDirectory() { return getVirtualDirectory() }, | |||
There was a problem hiding this comment.
I can't find where this is needed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR enables the user to reference a C# project compiled as a web assembly and invoke methods on imported "modules".
There are several things that need to be done: