Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Runtime abstraction #47

Merged
merged 16 commits into from
Mar 30, 2023
Merged

feat: Runtime abstraction #47

merged 16 commits into from
Mar 30, 2023

Conversation

MaloPolese
Copy link
Member

No description provided.

@MaloPolese MaloPolese self-assigned this Mar 15, 2023
@MaloPolese
Copy link
Member Author

@kalil-pelissier new PR

@MaloPolese MaloPolese mentioned this pull request Mar 15, 2023
Closed
12 tasks
@MaloPolese MaloPolese changed the title feat: WIP - refractor riklet codebase feat: WIP - Runtime abstraction Mar 15, 2023
@kalil-pelissier kalil-pelissier force-pushed the riklet-runtime-abstraction branch from fdf4165 to ab526e2 Compare March 16, 2023 16:57
@alexandrebrg alexandrebrg linked an issue Mar 19, 2023 that may be closed by this pull request
Add abstraction level around runtimes (containers/VMs) #56
Closed
11 tasks
@MaloPolese MaloPolese changed the title feat: WIP - Runtime abstraction feat: Runtime abstraction Mar 20, 2023
@MaloPolese MaloPolese requested a review from alexandrebrg March 20, 2023 18:41
@MaloPolese MaloPolese force-pushed the riklet-runtime-abstraction branch from 9d5637b to 60d7f95 Compare March 20, 2023 21:55
@MaloPolese MaloPolese marked this pull request as ready for review March 20, 2023 23:30
@MaloPolese MaloPolese requested a review from a team as a code owner March 20, 2023 23:30
@MaloPolese MaloPolese force-pushed the riklet-runtime-abstraction branch from b7264dc to 9a34c68 Compare March 21, 2023 12:13
alexandrebrg
alexandrebrg requested changes Mar 21, 2023
View reviewed changes
Copy link
Member

@alexandrebrg alexandrebrg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work! Some changes to be done, some of them could be converted into issues

riklet/src/main.rs Outdated Show resolved Hide resolved
riklet/src/utils.rs Show resolved Hide resolved
riklet/src/runtime/network/function_network.rs Outdated Show resolved Hide resolved
riklet/src/runtime/network/function_network.rs Outdated Show resolved Hide resolved
riklet/src/runtime/network/function_network.rs Outdated Show resolved Hide resolved
riklet/src/runtime/pod_runtime.rs Outdated Show resolved Hide resolved
riklet/src/runtime/pod_runtime.rs Outdated Show resolved Hide resolved
riklet/src/structs.rs Show resolved Hide resolved
riklet/src/structs.rs Outdated Show resolved Hide resolved
riklet/src/structs.rs Outdated Show resolved Hide resolved
@MaloPolese MaloPolese force-pushed the riklet-runtime-abstraction branch from a476998 to e8c07b4 Compare March 21, 2023 13:36
@kalil-pelissier kalil-pelissier force-pushed the riklet-runtime-abstraction branch from 3098615 to 8e59abb Compare March 24, 2023 17:02
@MaloPolese MaloPolese mentioned this pull request Mar 29, 2023
Closed
@MaloPolese MaloPolese force-pushed the riklet-runtime-abstraction branch from 3ebdbc0 to 86ef7f9 Compare March 29, 2023 19:10
JeremyLARDENOIS
JeremyLARDENOIS previously requested changes Mar 30, 2023
View reviewed changes
Copy link
Contributor

@JeremyLARDENOIS JeremyLARDENOIS left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There are two more generated errors in tap.rs whereas it's handled already, can you remove them?

riklet/src/network/tap.rs Show resolved Hide resolved
riklet/src/network/tap.rs Show resolved Hide resolved
@MaloPolese MaloPolese removed the request for review from JeremyLARDENOIS March 30, 2023 22:08
@MaloPolese MaloPolese merged commit 7a00d50 into main Mar 30, 2023
@MaloPolese MaloPolese deleted the riklet-runtime-abstraction branch March 30, 2023 22:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JeremyLARDENOIS JeremyLARDENOIS JeremyLARDENOIS left review comments

@kalil-pelissier kalil-pelissier kalil-pelissier approved these changes

@alexandrebrg alexandrebrg alexandrebrg approved these changes

Assignees

@MaloPolese MaloPolese

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add abstraction level around runtimes (containers/VMs)
4 participants
@MaloPolese @alexandrebrg @JeremyLARDENOIS @kalil-pelissier