Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(rime_api_console): recreate session when necessary #893

Merged
merged 1 commit into from
Jan 14, 2025

Conversation

ksqsf
Copy link
Member

@ksqsf ksqsf commented Jun 12, 2024

Pull request

synchronize will destroy previous sessions, and make future commands unusable.

Issue tracker

Fixes will automatically close the related issue

Fixes #

Feature

Describe feature of pull request

Unit test

  • Done

Manual test

  • Done

Code Review

  1. Unit and manual test pass
  2. GitHub Action CI pass
  3. At least one contributor reviews and votes
  4. Can be merged clean without conflicts
  5. PR will be merged by rebase upstream base

Additional Info

@ksqsf ksqsf changed the title fix(tools): recreate session when necessary fix(rime_api_console): recreate session when necessary Jun 12, 2024
@mirtlecn
Copy link

请 rime 开发者考虑一下检查一下此 PR。

如果没有此 PR,在 rime_api_console 中输入 synchronize 后,则无法再和程序交互,只能重启 rime_api_console,应当属于当初引入此功能时的遗漏。

@ksqsf ksqsf requested a review from a team January 12, 2025 15:22
tools/rime_api_console.cc Outdated Show resolved Hide resolved
tools/rime_api_console.cc Outdated Show resolved Hide resolved
@ksqsf
Copy link
Member Author

ksqsf commented Jan 13, 2025

@lotem Thanks. Comments addressed.

@lotem lotem merged commit 6f6f540 into rime:master Jan 14, 2025
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants