Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[DO NOT MERGE] test: rename all instances of data-test to data-testid #1015

Open
wants to merge 2 commits into
base: rtl
Choose a base branch
from

Conversation

mvadari
Copy link
Collaborator

@mvadari mvadari commented Jul 5, 2024

High Level Overview of Change

Context of Change

Type of Change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Refactor (non-breaking change that only restructures code)
  • Tests (You added tests for code that already exists, or your new feature included in this PR)
  • Documentation Updates
  • Translation Updates
  • Release

TypeScript/Hooks Update

  • Updated files to React Hooks
  • Updated files to TypeScript

Before / After

Test Plan

@mvadari mvadari force-pushed the data-testid branch 2 times, most recently from 71c5bbd to 2976fbe Compare July 10, 2024 16:31
@mvadari mvadari marked this pull request as ready for review July 29, 2024 14:33
@mvadari mvadari changed the title test: rename all instances of data-test to data-testid [DO NOT MERGE] test: rename all instances of data-test to data-testid Aug 23, 2024
@mvadari
Copy link
Collaborator Author

mvadari commented Aug 23, 2024

This is contingent on #945

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants