For curve25519-dalek, overflow doesn't happen in field AddAssign for a collaborative prover #4
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR propose a different way to add two numbers for ed25519's Fq elements.
We observe that ed25519's Fq is smaller than 2^{255}. If the prover is collaborative, all the "denormalized" numbers should be small than 2^{255}, overflow should never happen. So, it is safe to enforce that the carry7.0 is zero.
With the assumption that carry7.0 is zero, we can use the mul_mod syscall to reduce it to be smaller than the modulus. For a collaborative prover, it can make sure that the result is smaller than 2^{255}. If a prover is not collaborative, the number may be higher---this would not be disastrous because if it doesn't cause an overflow, it is okay, if it causes an overflow, the code would detect and refuse.
This change reduces the number of cycles caused by AddAssign.