-
Notifications
You must be signed in to change notification settings - Fork 855
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Make methods of mem_t
virtual to allow overriding
#1415
Conversation
@aswaterman @jerryz123 I know this wasn't your preferred option when discussing this on #1408, but looking at the code now, I think it'd be a bit nicer if we separated the interface from the implementation: We could have an |
I'm OK with that alternative if @jerryz123 is. |
I have no problems with that. |
Great, I updated the PR with the changes. Let me know what you think! Thanks! 😄 |
Seems like there are some CI failures. |
Can you squash the two commits together? Each commit in PRs to this project is checked for functionality. |
@jerryz123 Done! 😃 (BTW is there a way for me to trigger the tests?) |
This change allows to create custom implementations of `abstract_mem_t` and inject them when constructing `sim_t`. The current `mem_t` implementation remains unchanged. Fixes riscv-software-src#1408.
FYI: I missed one |
This allows the users to provide their own custom implementations of
mem_t
when constructingsim_t
.Fixes #1408.