-
Notifications
You must be signed in to change notification settings - Fork 855
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Legalize xenvcfg.CBIE #1416
Legalize xenvcfg.CBIE #1416
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Rather than repeating the constant 2
in multiple places, could we at least #define CBIE_RESERVED 2
in csrs.cc
?
6228719
to
9bbefab
Compare
Add |
6045a88
to
e64109c
Compare
Replace the global macro
|
e64109c
to
ca768f8
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks like this needs a rebase.
The value 2 of menvcfg.CBIE is reserved. This commit legalizes it to 0 by adding a specialized class envcfg_csr_t. Reference: riscv/riscv-CMOs#65
The value 2 of senvcfg.CBIE is reserved. This commit legalizes it to 0. Reference: riscv/riscv-CMOs#65
The value 2 of henvcfg.CBIE is reserved. This commit legalizes it to 0. Reference: riscv/riscv-CMOs#65
ca768f8
to
e7e1880
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for your patience.
The value 2 of xenvcfg.CBIE is reserved. This PR legalizes it to 0.
The values 2 and 0 of xenvcfg.CBIE do not have corresponding macros. Thus, this PR hard-codes those values.
Reference: riscv/riscv-CMOs#65