Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

mmu: fetch instruction bytes in ascending order #1419

Merged
merged 1 commit into from
Jul 18, 2023

Conversation

poemonsense
Copy link
Contributor

Fetching instruction bytes in descending order would result in wrong xtval update values.

See #1418

Fetching instruction bytes in descending order would result in
wrong xtval update values.
Copy link
Collaborator

@aswaterman aswaterman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@scottj97 and/or @jerryz123 please provide a sanity-check on this one. I think it's the right solution to #1418.

Copy link
Collaborator

@jerryz123 jerryz123 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The analysis in #1418 makes sense to me

@aswaterman aswaterman merged commit 3713532 into riscv-software-src:master Jul 18, 2023
3 checks passed
@poemonsense poemonsense deleted the fix-fetch-order branch July 18, 2023 07:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants