hvip: Correct logging value of mip on writing hvip #1741
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The logging value is the read value on updating. The read value of mip depends on the value of hvip. Updating mip before hvip leaves an incorrect logging mip value that does not consider the new hvip. Thus, updating mip should be after basic_csr_t::unlogged_write() of hvip to log the correct value. The return value of basic_csr_t::unlogged_write() is a constant true. Thus, the return value does not change after this commit.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I found an issue in commit 20a7354. Sorry for the mistake.
The logging value is the read value on updating. The read value of mip depends on the value of hvip. Updating mip before hvip leaves an incorrect logging mip value that does not consider the new hvip. Thus, updating mip should be after
basic_csr_t::unlogged_write()of hvip to log the correct value.The return value of basic_csr_t::unlogged_write() is a constant true. Thus, the return value does not change after this commit.