triggers: Let mcontrol.match be default (0/equal) if maskmax is 0 #1786
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
YenHaoChen
commented
Aug 27, 2024
| @@ -294,13 +294,14 @@ void mcontrol6_t::tdata1_write(processor_t * const proc, const reg_t val, const | |||
| auto xlen = proc->get_const_xlen(); | |||
| assert(get_field(val, CSR_MCONTROL6_TYPE(xlen)) == CSR_TDATA1_TYPE_MCONTROL6); | |||
| dmode = get_field(val, CSR_MCONTROL6_DMODE(xlen)); | |||
| const reg_t maskmax6 = xlen - 1; | |||
There was a problem hiding this comment.
@rtwfroody I didn't find an explicit upper bound for maskmax6 in the Debug spec. Does the spec intend maskmax6=31 in RV32 and maskmax6=63 in RV64 for maximum?
There was a problem hiding this comment.
Yes. It doesn't make sense for maskmax6 to be any larger than that, because then you're just doing an equal comparison.
Comment on lines
+250
to
-251
| case MATCH_NAPOT: if (maskmax == 0) return MATCH_EQUAL; | ||
| case MATCH_EQUAL: | ||
| case MATCH_NAPOT: |
There was a problem hiding this comment.
This seems tricky. Invite comment on this modification.
rtwfroody
approved these changes
Aug 27, 2024
aswaterman
approved these changes
Aug 27, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes the issue in #1785.
Specifically, the spec requires unsupporting
mcontrol.match=NAPOTifmcontrol.maskmax=0.