Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove --with-isa/priv compile flags #1807

Merged
merged 3 commits into from
Sep 14, 2024
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 0 additions & 6 deletions config.h.in
Original file line number Diff line number Diff line change
Expand Up @@ -6,12 +6,6 @@
/* Define if subproject MCPPBS_SPROJ_NORM is enabled */
#undef CUSTOMEXT_ENABLED

/* Default value for --isa switch */
#undef DEFAULT_ISA

/* Default value for --priv switch */
#undef DEFAULT_PRIV

/* Define if subproject MCPPBS_SPROJ_NORM is enabled */
#undef DISASM_ENABLED

Expand Down
33 changes: 0 additions & 33 deletions configure
Original file line number Diff line number Diff line change
Expand Up @@ -737,8 +737,6 @@ with_boost
with_boost_libdir
with_boost_asio
with_boost_regex
with_isa
with_priv
with_target
enable_dual_endian
'
Expand Down Expand Up @@ -1403,9 +1401,6 @@ Optional Packages:
use the Regex library from boost - it is possible to
specify a certain library for the linker e.g.
--with-boost-regex=boost_regex-gcc-mt-d-1_33_1
--with-isa=RV64IMAFDC_zicntr_zihpm
Sets the default RISC-V ISA
--with-priv=MSU Sets the default RISC-V privilege modes supported
--with-target=riscv64-unknown-elf
Sets the default target config

Expand Down Expand Up @@ -6562,34 +6557,6 @@ fi



# Check whether --with-isa was given.
if test ${with_isa+y}
then :
withval=$with_isa;
printf "%s\n" "#define DEFAULT_ISA \"$withval\"" >>confdefs.h

else $as_nop

printf "%s\n" "#define DEFAULT_ISA \"RV64IMAFDC_zicntr_zihpm\"" >>confdefs.h

fi



# Check whether --with-priv was given.
if test ${with_priv+y}
then :
withval=$with_priv;
printf "%s\n" "#define DEFAULT_PRIV \"$withval\"" >>confdefs.h

else $as_nop

printf "%s\n" "#define DEFAULT_PRIV \"MSU\"" >>confdefs.h

fi



# Check whether --with-target was given.
if test ${with_target+y}
then :
Expand Down
1 change: 1 addition & 0 deletions disasm/disasm.cc
Original file line number Diff line number Diff line change
Expand Up @@ -2,6 +2,7 @@

#include "disasm.h"
#include "decode_macros.h"
#include "platform.h"
#include <cassert>
#include <string>
#include <vector>
Expand Down
2 changes: 2 additions & 0 deletions riscv/platform.h
Original file line number Diff line number Diff line change
Expand Up @@ -4,6 +4,8 @@

#define DEFAULT_KERNEL_BOOTARGS "console=ttyS0 earlycon"
#define DEFAULT_RSTVEC 0x00001000
#define DEFAULT_ISA "rv64imafdc_zicntr_zihpm"
#define DEFAULT_PRIV "MSU"
#define CLINT_BASE 0x02000000
#define CLINT_SIZE 0x000c0000
#define PLIC_BASE 0x0c000000
Expand Down
12 changes: 0 additions & 12 deletions riscv/riscv.ac
Original file line number Diff line number Diff line change
Expand Up @@ -8,18 +8,6 @@ AC_CHECK_LIB([boost_system], [main], [], [])

AC_CHECK_LIB([boost_regex], [main], [], [])

AC_ARG_WITH(isa,
[AS_HELP_STRING([--with-isa=RV64IMAFDC_zicntr_zihpm],
[Sets the default RISC-V ISA])],
AC_DEFINE_UNQUOTED([DEFAULT_ISA], "$withval", [Default value for --isa switch]),
AC_DEFINE_UNQUOTED([DEFAULT_ISA], "RV64IMAFDC_zicntr_zihpm", [Default value for --isa switch]))

AC_ARG_WITH(priv,
[AS_HELP_STRING([--with-priv=MSU],
[Sets the default RISC-V privilege modes supported])],
AC_DEFINE_UNQUOTED([DEFAULT_PRIV], "$withval", [Default value for --priv switch]),
AC_DEFINE_UNQUOTED([DEFAULT_PRIV], "MSU", [Default value for --priv switch]))

AC_ARG_WITH(target,
[AS_HELP_STRING([--with-target=riscv64-unknown-elf],
[Sets the default target config])],
Expand Down
2 changes: 1 addition & 1 deletion spike_dasm/spike-dasm.cc
Original file line number Diff line number Diff line change
Expand Up @@ -6,9 +6,9 @@
// enclosed hexadecimal number, interpreted as a RISC-V
// instruction.

#include "config.h"
#include "disasm.h"
#include "extension.h"
#include "platform.h"
#include <iostream>
#include <string>
#include <cstdint>
Expand Down
2 changes: 1 addition & 1 deletion spike_main/spike-log-parser.cc
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,6 @@
// in its inputs, then output the RISC-V instruction with the disassembly
// enclosed hexadecimal number.

#include "config.h"
#include <iostream>
#include <string>
#include <cstdint>
Expand All @@ -14,6 +13,7 @@

#include "disasm.h"
#include "extension.h"
#include "platform.h"

using namespace std;

Expand Down
Loading