Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make the non-existent csr configurable #513

Merged
merged 1 commit into from
Oct 17, 2023
Merged

Make the non-existent csr configurable #513

merged 1 commit into from
Oct 17, 2023

Conversation

lz-bro
Copy link
Contributor

@lz-bro lz-bro commented Oct 16, 2023

#504 Make the non-existent csr configurable

timsifive
timsifive requested changes Oct 16, 2023
View reviewed changes
Copy link
Collaborator

@timsifive timsifive left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, but can you add ${nonexist_csr} to the assertion error message?

@lz-bro
Copy link
Contributor Author

lz-bro commented Oct 17, 2023

I have added ${nonexist_csr} to the assertion error message.

@timsifive timsifive merged commit d020e20 into riscv-software-src:master Oct 17, 2023
2 checks passed
@lz-bro lz-bro deleted the nonexist_csr branch January 23, 2024 15:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@timsifive timsifive timsifive approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@lz-bro @timsifive