Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

debug: Fix loading of empty exclude lists with comments #554

Merged
merged 1 commit into from
May 4, 2024

Conversation

MarekVCodasip
Copy link
Contributor

@MarekVCodasip MarekVCodasip commented May 2, 2024

This patch fixes the case when we are using an empty exception list (for example just a YAML file with comments but without any test items to skip).

debug/testlib.py Outdated Show resolved Hide resolved
Copy link

@JanMatCodasip JanMatCodasip left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for the improvement. I have just posted one cosmetic suggestion.

It looks good to me.

This patch fixes the case when we are using an empty exception list (for example just a YAML file with comments but without any test items to skip).
@MarekVCodasip
Copy link
Contributor Author

@en-sc FYI, if you want to take a look.

Copy link
Collaborator

@en-sc en-sc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@aap-sc aap-sc merged commit 89a45c0 into riscv-software-src:master May 4, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants