Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix C.MODESW encoding so it doesn't overlap C.SUBW #137

Merged
merged 1 commit into from
Feb 27, 2024

Conversation

tariqkurd-repo
Copy link
Collaborator

I've changed this to the intended encoding, which is already in riscv-opcodes.
The previous one was a typo and conflicted with c.subw

Copy link
Collaborator

@arichardson arichardson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I was not aware of the riscv-opcodes change, maybe include pointer to riscv/riscv-opcodes#214 in the commit message when you squash and merge?

@arichardson arichardson merged commit bda7ade into riscv:main Feb 27, 2024
3 checks passed
@tariqkurd-repo
Copy link
Collaborator Author

riscv/riscv-opcodes#214 is the reference. I had incorrectly typed in the encoding into this doc, which this PR fixed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants