Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Better description of how etrigger matches. #1085

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Better description of how etrigger matches. #1085

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 7 additions & 5 deletions xml/hwbp_registers.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1252,11 +1252,13 @@ same project unless stated otherwise.

This register is accessible as {csr-tdata1} when {tdata1-type} is 5.

This trigger may fire on up to XLEN of the Exception Codes defined in
`mcause` (described in the Privileged Spec, with Interrupt=0). Those
causes are configured by writing the corresponding bit in {csr-tdata2}.
(E.g. to trap on an illegal instruction, the debugger sets bit 2 in
{csr-tdata2}.)
This trigger can match when a trap is taken due to an exception.
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This feels like a very wish-washy statement.

How about:
This trigger matches when an exception is taken and the bit corresponding to the exception is set in tdata2.

Probably requires rewriting the paragraph below for it all to make sense.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This feels like a very wish-washy statement.

I agree. I didn't like the phrasing but I was trying to match the existing itrigger description which was updated last year. I was trying to limit the scope of this change but maybe we should update itrigger, too.


The trigger may be configured to match on up to XLEN of the Exception
Codes defined in `mcause` (described in the Privileged Spec, with
Interrupt=0). Those causes are configured by writing the corresponding
bit in {csr-tdata2}. (e.g. to have etrigger match on an illegal
instruction trap, the debugger sets bit 2 in {csr-tdata2}.)

[NOTE]
====
Expand Down