Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Minor fixes to table layout. #996

Merged
merged 3 commits into from
Mar 28, 2024
Merged

Minor fixes to table layout. #996

merged 3 commits into from
Mar 28, 2024

Conversation

rtwfroody
Copy link
Collaborator

Addresses #993.

@rtwfroody
Fix debugger implementation tables.
59f1bf4 
Sometimes they would wrap "Write", as pointed out in #993.
@rtwfroody
Give more space for field name in tables.
3e11244 
Fixes alignment of the field name within the tables, as pointed out in
@rtwfroody
Left align numbers in abstract commands table.
5496129 
Still doesn't look quite right, but right aligning makes no sense for a
range.
pdonahue-ventana
pdonahue-ventana approved these changes Mar 27, 2024
View reviewed changes
Copy link
Collaborator

@pdonahue-ventana pdonahue-ventana left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I basically just reviewed that this doesn't appear to change anything but formatting. I didn't look at the PDF to see that the new formatting is sensible, though I assume that you did that.

@rtwfroody rtwfroody merged commit 6ef54b6 into main Mar 28, 2024
1 check passed
@rtwfroody rtwfroody deleted the tables branch March 28, 2024 16:20
@rtwfroody rtwfroody added 1.0 asciidoc asciidoc conversion labels May 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pdonahue-ventana pdonahue-ventana pdonahue-ventana approved these changes

Assignees
No one assigned
Labels
1.0 asciidoc asciidoc conversion
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@rtwfroody @pdonahue-ventana