issue #411 - Clarify that smclicshv ignores 1 or 2 LSBs of vector table entry (depending on IALIGN) #417
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…le entry (depending on IALIGN)
christian-herber-nxp
requested changes
Sep 24, 2024
|
One suggestion still around mask: Let's rename to VTMASK, then this is consistent with VTBASE and a little bit more self-explaining |
|
Will rename MASK to VTMASK as requested. |
christian-herber-nxp
approved these changes
Sep 24, 2024
|
lgtm. Make sure to squash and merge once done to avoid having all the commits on master. |
jb-brelot-nxp
approved these changes
Sep 25, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Note that the CLIC spec in all but one location was assuming masking for only the IALIGN=16 case. In that one location, it said:
Note, next_pc is passed to fetch unit which will ignore 1 or 2 LSBs depending to IALIGN, so the masking is not shown above..So, the CLIC spec already assumed the masking/ignoring of 1 or 2 LSBs is a function of IALIGN so with this PR, it now says that consistently and more clearly.