Add basic pre-commit config, apply fixes and run it in CI #292
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This is a misleading PR title; it suggests no changes to the actual code. I don’t have a problem with that aspect of the PR contents, but please do try to employ accurate PR titles. @IIITM-Jay please review. |
IIITM-Jay
reviewed
Oct 5, 2024
Timmmm
changed the title
To avoid an enormouse commit, pylint and pyright are commented out for now.
Timmmm
force-pushed
the
user/timh/precommit
branch
from
3e1dbb0
to
3ba18d3
Compare
aswaterman
approved these changes
Oct 7, 2024
|
@Timmmm @IIITM-Jay After merging, a post-merge check is failing, probably because of a formatting error that has been inserted since this PR was created. Can either of you look into it and file a PR to get things passing again? https://github.com/riscv/riscv-opcodes/actions/runs/11225349353/job/31203877551 |
|
Ah probably a race with another PR. I'll fix it! |
|
Thank you! |
Timmmm
added a commit
to Timmmm/riscv-opcodes
that referenced
this pull request
Oct 8, 2024
This little bit of code from riscv#268 was not formatted in riscv#292 because it was not merged yet. Basically it was a semantic conflict between the PRs, but not a text conflict, so Git can't detect it. This can be prevented using merge queues, but it probably isn't necessary on a repo of this size.
|
#296 should fix it. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add a basic pre-commit config to format Python files using Black, and run it in CI. The second commit in this MR contains the actual formatting fixes.
I will fix the Pylint failures and add types in future MRs so that they can be enabled.