Stop including pseudo instructions in output for Go #303
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Go really only needs the instruction encodings for actual instructions. Additional pseudo-encodings have since been added to the riscv-opcodes generation, which also include instructions that are aliased to themselves (e.g. AJALPSEUDO/AJALRPSEUDO). Instead of dealing with these complications, stop including pseudo instructions in the output for Go and we'll synthesise pseudo instructions that we need. Add -pseudo which can be used to enable the generation of pseudo-instructions, restoring the previous behaviour.
aswaterman
approved these changes
Oct 25, 2024
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Go really only needs the instruction encodings for actual instructions. Additional pseudo-encodings have since been added to the riscv-opcodes generation, which also include instructions that are aliased to themselves (e.g. AJALPSEUDO/AJALRPSEUDO). Instead of dealing with these complications, stop including pseudo instructions in the output for Go and we'll synthesise the pseudo instructions that we need.
Add -pseudo which can be used to enable the generation of pseudo-instructions, restoring the previous behaviour.
Fixes #286