Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use argparse for argument parsing #314

Closed
wants to merge 2 commits into from

Conversation

Timmmm
Copy link
Contributor

@Timmmm Timmmm commented Nov 5, 2024

This is more maintainable and scalable and gives better errors and a nice --help message. The interface is compatible with the previous version.

Copy link

codecov bot commented Nov 5, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 74.01%. Comparing base (383cbca) to head (7ce8046).
Report is 6 commits behind head on master.

❗ There is a different number of reports uploaded between BASE (383cbca) and HEAD (7ce8046). Click for more details.

HEAD has 5 uploads less than BASE
Flag BASE (383cbca) HEAD (7ce8046)
10 5
Additional details and impacted files
@@             Coverage Diff             @@
##           master     #314       +/-   ##
===========================================
- Coverage   96.53%   74.01%   -22.52%     
===========================================
  Files          10        3        -7     
  Lines         750      408      -342     
===========================================
- Hits          724      302      -422     
- Misses         26      106       +80     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

This is more maintainable and scalable and gives better errors and a nice `--help` message. The interface is compatible with the previous version.
@Timmmm Timmmm force-pushed the user/timh/argparse branch from ba63ff5 to 1fa46f7 Compare December 20, 2024 14:04
@Timmmm
Copy link
Contributor Author

Timmmm commented Dec 20, 2024

@aswaterman @IIITM-Jay please could I get a review of this?

@aswaterman
Copy link
Member

Manually merged via #331

@aswaterman aswaterman closed this Dec 20, 2024
@Timmmm
Copy link
Contributor Author

Timmmm commented Dec 21, 2024

Thanks!

@aswaterman
Copy link
Member

You're welcome!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants