Sort JSON output #315
Merged
Sort JSON output #315
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #315 +/- ##
==========================================
- Coverage 96.53% 96.52% -0.01%
==========================================
Files 10 10
Lines 750 749 -1
==========================================
- Hits 724 723 -1
Misses 26 26 ☔ View full report in Codecov by Sentry. |
If we're sorting the dictionary anyway we may as well output the JSON sorted. Also since Python 3.6 we can just use `dict()` since the insertion order is preserved.
Timmmm
force-pushed
the
user/timh/sort_json
branch
from
21fd84c to
aef4cce
Compare
|
@aswaterman @IIITM-Jay please could I get a review of this? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If we're sorting the dictionary anyway we may as well output the JSON sorted.
Also since Python 3.6 we can just use
dict()since the insertion order is preserved.