Switch Fence.tso to not pseudo

[AFOliveira]

Just to get complient with the ISA Manual as clarified in riscv/riscv-isa-manual#1782

[codecov]

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 74.01%. Comparing base (383cbca) to head (8a8b738).
Report is 6 commits behind head on master.

❗ There is a different number of reports uploaded between BASE (383cbca) and HEAD (8a8b738). Click for more details.

HEAD has 5 uploads less than BASE

Flag	BASE (383cbca)	HEAD (8a8b738)
	10	5

Additional details and impacted files

@@             Coverage Diff             @@
##           master     #330       +/-   ##
===========================================
- Coverage   96.53%   74.01%   -22.52%     
===========================================
  Files          10        3        -7     
  Lines         750      408      -342     
===========================================
- Hits          724      302      -422     
- Misses         26      106       +80     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[AFOliveira]

This failed because they overlap (which I guess they should), should I go in the code and make this not an error?

[aswaterman]

Or just leave it as a pseudo for pragmatic reasons.

[AFOliveira]

Or just leave it as a pseudo for pragmatic reasons.

Well, that would definitely be easier :), but can't this be problematic for users of the outputs? I realized that many outputs don't use pseudo, so couldn't it be misleading?

[aswaterman]

The reason that it isn't problematic in practice is that it is deliberate that the FENCE encoding subsumes the FENCE.TSO encoding: the FENCE encoding is such that, if you ignore the bit that distinguishes FENCE.TSO from FENCE, the processor will still do the right thing (but in a slightly more conservative fashion).

So I don't want to spend time solving a problem that need not be solved.

[AFOliveira]

I understand, thank you for the clarification @aswaterman.

[aswaterman]

You're welcome, and thanks for playing ball.