Merge pull request #11 from dr-sc/fix_l2_bound

Fix L2_BOUND TMA metric formula
riscv · Oct 25, 2024 · 83c7d1b · 83c7d1b
2 parents ab34ec3 + d6939f8
commit 83c7d1b
Show file tree

Hide file tree

Showing 2 changed files with 2 additions and 2 deletions.
diff --git a/adoc_event_tables/topdown_metrics.adoc b/adoc_event_tables/topdown_metrics.adoc
@@ -21,7 +21,7 @@
 |TOPDOWN.BACKEND_BOUND.MEMORY_BOUND.ADDR_BOUND.PAGE_WALK_BOUND.RATE |Fraction of slots wasted while waiting for address translation which needed page walk (missed all TLB levels) |TOPDOWN.BACKEND_BOUND.MEMORY.ADDR.TLB.L2_MISS.SLOTS / TOPDOWN.SLOTS
 |TOPDOWN.BACKEND_BOUND.MEMORY_BOUND.DATA_BOUND.RATE |Fraction of slots wasted while waiting for data |TOPDOWN.BACKEND_BOUND.MEMORY.DATA.SLOTS / TOPDOWN.SLOTS
 |TOPDOWN.BACKEND_BOUND.MEMORY_BOUND.DATA_BOUND.L1_BOUND.RATE |Fraction of slots unused due to the stalls caused by load instructions which got data from L1 data cache |(TOPDOWN.BACKEND_BOUND.MEMORY.DATA.SLOTS - TOPDOWN.BACKEND_BOUND.MEMORY.DATA.L1_MISS.SLOTS) / TOPDOWN.SLOTS
-|TOPDOWN.BACKEND_BOUND.MEMORY_BOUND.DATA_BOUND.L2_BOUND.RATE |Fraction of slots unused due to the stalls caused by load instructions which got data from L2 cache |(TOPDOWN.BACKEND_BOUND.MEMORY.DATA.L1_MISS.SLOTS - TOPDOWN.BACKEND_BOUND.MEMORY.DATA.DATA.DATA.DATA.DATA.DATA.DATA.DATA.DATA.DATA.DATA.DATA.DATA.DATA.DATA.DATA.DATA.DATA.DATA.L2_MISS.SLOTS) / TOPDOWN.SLOTS
+|TOPDOWN.BACKEND_BOUND.MEMORY_BOUND.DATA_BOUND.L2_BOUND.RATE |Fraction of slots unused due to the stalls caused by load instructions which got data from L2 cache |(TOPDOWN.BACKEND_BOUND.MEMORY.DATA.L1_MISS.SLOTS - TOPDOWN.BACKEND_BOUND.MEMORY.DATA.L2_MISS.SLOTS) / TOPDOWN.SLOTS
 |TOPDOWN.BACKEND_BOUND.MEMORY_BOUND.DATA_BOUND.L3_BOUND.RATE |Fraction of slots unused due to the stalls caused by load instructions which got data from L3 cache |(TOPDOWN.BACKEND_BOUND.MEMORY.DATA.L2_MISS.SLOTS - TOPDOWN.BACKEND_BOUND.MEMORY.DATA.L3_MISS.SLOTS) / TOPDOWN.SLOTS
 |TOPDOWN.BACKEND_BOUND.MEMORY_BOUND.DATA_BOUND.EXTERNAL_MEM_BOUND.RATE |Fraction of slots unused due to the stalls caused by load instructions which got data from external memory |TOPDOWN.BACKEND_BOUND.MEMORY.DATA.L3_MISS.SLOTS / TOPDOWN.SLOTS
 |===

diff --git a/event_files/topdown_metrics.json b/event_files/topdown_metrics.json
@@ -146,7 +146,7 @@
     {
         "MetricName": "TOPDOWN.BACKEND_BOUND.MEMORY_BOUND.DATA_BOUND.L2_BOUND.RATE",
         "BriefDescription": "Fraction of slots unused due to the stalls caused by load instructions which got data from L2 cache",
-        "MetricExpr": "(TOPDOWN.BACKEND_BOUND.MEMORY.DATA.L1_MISS.SLOTS - TOPDOWN.BACKEND_BOUND.MEMORY.DATA.DATA.DATA.DATA.DATA.DATA.DATA.DATA.DATA.DATA.DATA.DATA.DATA.DATA.DATA.DATA.DATA.DATA.DATA.L2_MISS.SLOTS) / TOPDOWN.SLOTS",
+        "MetricExpr": "(TOPDOWN.BACKEND_BOUND.MEMORY.DATA.L1_MISS.SLOTS - TOPDOWN.BACKEND_BOUND.MEMORY.DATA.L2_MISS.SLOTS) / TOPDOWN.SLOTS",
         "MetricThreshold": "TOPDOWN.BACKEND_BOUND.MEMORY_BOUND.L2_BOUND.RATE > 0.1",
         "PublicDescription": "Fraction of slots unused due to the stalls caused by load instructions which got data from L2 cache",
         "ScaleUnit": "100%"