Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Extend import of key signatures #3487

Merged
merged 2 commits into from
Jul 18, 2023

Conversation

rettinghaus
Copy link
Contributor

This PR adds support for sori and koron accidentals and smufl values in key signatures to MusicXML import.

image

<?xml version="1.0" encoding="UTF-8"?>
<!DOCTYPE score-partwise PUBLIC "-//Recordare//DTD MusicXML 4.0 Partwise//EN" "http://www.musicxml.org/dtds/partwise.dtd">
<score-partwise version="4.0">
  <work>
    <work-title>Persian key</work-title>
    </work>
  <identification>
    <creator type="encoder">Klaus Rettinghaus</creator>
    </identification>
  <part-list>
    <score-part id="P1">
      <part-name>Stimme</part-name>
      <part-abbreviation>St.</part-abbreviation>
      <score-instrument id="P1-I1">
        <instrument-name>Stimme</instrument-name>
        <instrument-sound>voice.vocals</instrument-sound>
        </score-instrument>
      <midi-device id="P1-I1" port="1"></midi-device>
      <midi-instrument id="P1-I1">
        <midi-channel>1</midi-channel>
        <midi-program>53</midi-program>
        <volume>78.7402</volume>
        <pan>0</pan>
        </midi-instrument>
      </score-part>
    </part-list>
  <part id="P1">
    <measure number="1">
      <attributes>
        <divisions>1</divisions>
        <key>
          <key-step>C</key-step>
          <key-alter>0.33</key-alter>
          <key-accidental>sori</key-accidental>
          <key-step>E</key-step>
          <key-alter>-0.67</key-alter>
          <key-accidental>koron</key-accidental>
          <key-step>B</key-step>
          <key-alter>-0.67</key-alter>
          <key-accidental>koron</key-accidental>
          <key-step>F</key-step>
          <key-alter>0.33</key-alter>
          <key-accidental smufl="">sori</key-accidental>
          </key>
        <time>
          <beats>4</beats>
          <beat-type>4</beat-type>
          </time>
        <clef>
          <sign>G</sign>
          <line>2</line>
          </clef>
        </attributes>
      <note>
        <rest measure="yes"/>
        <duration>4</duration>
        <voice>1</voice>
        </note>
      </measure>
    </part>
  </score-partwise>

@lpugin lpugin merged commit 03c62dc into rism-digital:develop Jul 18, 2023
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants