Menambahkan kode untuk menghandle akun dengan > 1 role/kode_org #11
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
oke, di-review dulu ya, sorry agak lama, hehe |
fatanugraha
suggested changes
Aug 23, 2019
SSO/SSO.php
Outdated
| $user->study_program = $data['study_program']; | ||
| $user->educational_program = $data['educational_program']; | ||
| } else { | ||
| $user->faculty = array(); |
There was a problem hiding this comment.
We might want to keep this property's type consistent to make sure existing apps that use this library did not break.
One that i can suggest is keep faculty, study_program, and educational_program to contain the first role, and put the others to another property.
When more than 1 `kd_org` is present for a single user, additional faculty, study_program, and educational_program are stored in properties named after their plural forms, as arrays. This is done to ensure type consistency of existing properties.
|
Hi, Sorry for letting this off for months. Thank you for the feedback, added commit 13667ee to address this issue. |
Add Sub Specialist Program FK (ristekoss#9)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Solusi sederhana untuk issue #10
Mungkin perlu dipikirkan adanya kemungkinan bahwa bukan hanya mahasiswa yang dapat memiliki >1 role?