Update JacksonXml project for Java 11 #535
Conversation
|
Why is the missing dependency causing problems under Java 11, but did not under Java 8? |
|
The java runtime library was was divided and reorganized for Java 9+. Thus the addition of the jaxc-api jar file. |
|
Since the Ant build files are generated from Maven, is it possible to add that dependency also to the original pom.xml after checkout (post-checkout hook)? While D4J is using the generated Ant build files, I am worried that this change to a generated file may be unexpected and will go unnoticed if anyone tries to mine additional bugs for this project. Specifically, I am proposing to add an additional dependency to the pom.xml after checkout; running mvn ant:ant on this modified pom.xml should generate the same, fixed maven-build.xml files. |
|
I can add the dependency to the pom but there is a problem. 'mvn ant:ant' fails as the pom refers to jackson-databind/2.7.0-rc4-SNAPSHOT which is in framework/projects/JacksonXml/lib but is not in maven central. I changed the pom to 2.7.0-rc3 just to test 'mvn ant:ant' and that seemed to work. Not sure what to do. |
|
Can you add the local lib folder that contains the databind snapshot version to the pom.xml? If not, changing the dependency to 2.7.0-rc3 in the pom.xml seems fine. |
|
This last set of changes don't change anything to do with running the tests. They are only if somebody runs 'mvn ant:ant' by hand the will get the same maven-build files as currently checked in. |
|
@rjust Could you please review this? |
remove unneeded buggy build files
add missing dependency on jaxb-api-2.3.0.jar