hugo server settings by type #203
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
🎉 The preview is built! Check it out |
cosimameyer
approved these changes
Aug 15, 2023
|
Not sure if it’s on purpose but the build & deploy (production) job was skipped (since we’ve changes in the production .tomls (as far as I’ve seen), I’m wondering if we shouldn’t check it as well). If not, I’m absolutely fine with merging it 🙌 |
|
production should be skipped in a PR, but the preview is built in stead. then when merged, hopefully, production will be run but preview skipped :) |
|
But I see what you mean! Let me have a think on how we can do that. for now this should be good. but we should have a think if we have a better way of testing production (as we have seen it fail) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Moving some build settings into the configuration of hugo instead of hardcoded in github workflow.
This way, when people work locally, hugo will behave the same for all, not needing to rely on specific build commands.