Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

highlight leadership & unify image size #297

Merged
merged 6 commits into from
Feb 14, 2024
Merged

highlight leadership & unify image size #297

merged 6 commits into from
Feb 14, 2024

Conversation

drmowinckels
Copy link
Member

@drmowinckels drmowinckels commented Feb 6, 2024

these changes should appear on the Global team page, where Leadership now has its own grid, as the old website did.

This is to make it clearer the current Leadership of R-Ladies.

@drmowinckels drmowinckels requested a review from a team as a code owner February 6, 2024 09:03
@shannonpileggi
Copy link
Contributor

When I build the website locally the new addition In About -> Global Team looks great, approved on that!

But on the front page I also see this:
image

Has this snuck into this PR somehow? I don't see it in the live version.

@drmowinckels
Copy link
Member Author

This is an effect of the build preview not fetching the directory, but rather using the built-in data.
We did this to enable hugo builds (but not true previews) also from forks, which would not have access to the secrets needed to clone the directory.

It also significantly reduces build time.

So this is expected behaviour.

Copy link

🎉 The preview is built! Check it out 👀

@drmowinckels drmowinckels merged commit 06c0f81 into main Feb 14, 2024
2 checks passed
@drmowinckels drmowinckels deleted the leadership branch February 14, 2024 10:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants