dont fail on remote r-ladies blog image unavailable #333
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Test build failed 😭 Check out the build logs. |
|
Test build failed 😭 Check out the build logs. |
|
actually this partially works, and I'm unsure why its really failing. The code is more or less right out of hugo docs (https://gohugo.io/functions/resources/getremote/#error-handling) Locally, it manages to deal with incorrect image url just fine. And if you check the build, and click on the image links that are erroring, none of them actually exist (all are giving 404). I'm trying to understand what up and make a workaround in this PR, just not there yet, unfortunately. |
|
🎉 The preview is built! Check it out 👀 |
|
found it! I needed to warn rather than error on missing image. Quite obviously :) |
cosimameyer
approved these changes
Apr 19, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Will allow the website to build even if the image listed for the R-Ladies blog is no longer available. The image will be replaced with a random gravatar.