Update TokenPropertiesRepository to ERC-7508 #228
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Token properites repository has now been proposed as ERC-7508 and the changes in the commit reflect the new proposal.
steven2308
approved these changes
Sep 8, 2023
CHANGELOG.md
Outdated
| | **Statements** | 100.00 % | 100.00 % | + 0.00 % | | ||
| | **Branches** | 95.53 % | 96.78 % | + 1.25 % | | ||
| | **Functions** | 99.60 % | 99.72 % | + 0.12 % | | ||
| | **Lines** | 99.63 % | 99.46 % | - 0.17 % | |
There was a problem hiding this comment.
Let's undo this changes.
| private _emotesUsedByEmoter; // Cheaper than using a bool | ||
| mapping(address collection => mapping(uint256 tokenId => mapping(string emoji => uint256 count))) | ||
| mapping(address => mapping(uint256 => mapping(string => uint256))) |
There was a problem hiding this comment.
Let's undo this changes.
There was a problem hiding this comment.
Damn, didn't we fix prettier removing the parameter names? 🤔
| @@ -20,7 +20,7 @@ error InsufficientBalance(); | |||
| * @dev The RMRKTokenHolder extension is capable of holding ERC-20, ERC-721, and ERC-1155 tokens. | |||
| */ | |||
| abstract contract RMRKTokenHolder is IRMRKTokenHolder { | |||
| mapping(uint256 tokenId => mapping(address tokenAddress => mapping(TokenType tokenType => mapping(uint256 heldTokenId => uint256 balance)))) | |||
| mapping(uint256 => mapping(address => mapping(TokenType => mapping(uint256 => uint256)))) | |||
There was a problem hiding this comment.
Let's undo this changes.
steven2308
approved these changes
Sep 11, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The token properties repository has been proposed as ERC-7508, and the commit changes reflect the new proposal.
Checklist
PR-Codex overview
Detailed summary
docs/RMRK/extension/tokenProperties/RMRKTokenPropertiesRepository.mdtest/interfaces.ts.IRMRKTokenPropertiesRepositoryto'0x003f5b32'.IERC7508to'0x07cd44c7'.networkvalue inhardhat.config.tsfor bothbaseGoerliandbase.RMRKTokenAttributesRepositorysmart contract.