Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

V2.1.0 #229

Merged
merged 14 commits into from
Sep 20, 2023
Merged

V2.1.0 #229

merged 14 commits into from
Sep 20, 2023

Conversation

steven2308
Copy link
Collaborator

@steven2308 steven2308 commented Sep 19, 2023

Description

Describe the additions/improvements this PR contains.

Checklist

  • Verified code additions
  • Updated NatSpec comments (if applicable)
  • Regenerated docs
  • Ran prettier
  • Added tests to fully cover the changes

PR-Codex overview

This PR focuses on updating the interfaces and contracts related to the RMRK nestable module.

Detailed summary

  • Renamed IRMRKEmotesRepository to IERC7409
  • Updated package.json version to "2.1.0"
  • Updated imports in various contracts to use the new interfaces:
    • RMRKNestableAutoIndex.sol
    • RMRKReclaimableChild.sol
    • RMRKNestableMock.sol
    • ChildAdder.sol
    • RMRKNestableTypedMultiAssetMock.ts
    • RMRKCore.sol
    • RMRKEquipRenderUtils.sol
    • RMRKRenderUtils.sol
    • RMRKEquippable.sol
  • Updated references to interface names in tests and documentation

The following files were skipped due to too many changes: test/extensions/reclaimableChild.ts, test/implementations/generalBehavior.ts, .env.example, contracts/RMRK/utils/RMRKCollectionUtils.sol, test/renderUtils.ts, CHANGELOG.md, docs/mocks/RMRKEquippableMock.md, docs/mocks/RMRKNestableMock.md, docs/RMRK/nestable/RMRKNestable.md, docs/RMRK/equippable/RMRKEquippable.md, docs/mocks/RMRKMinifiedEquippableMock.md, docs/mocks/RMRKNestableMultiAssetMock.md, docs/RMRK/nestable/RMRKNestableMultiAsset.md, test/behavior/nestable.ts, docs/RMRK/equippable/RMRKMinifiedEquippable.md, docs/mocks/RMRKNestableAutoIndexMock.md, docs/RMRK/extension/reclaimableChild/RMRKReclaimableChild.md, docs/implementations/premint/RMRKEquippablePreMint.md, docs/implementations/premint/RMRKNestablePreMint.md, docs/implementations/abstract/RMRKAbstractEquippable.md, docs/implementations/abstract/RMRKAbstractNestable.md, docs/mocks/extensions/soulbound/RMRKSoulboundEquippableMock.md, docs/mocks/extensions/soulbound/RMRKSoulboundNestableMock.md, docs/mocks/extensions/typedMultiAsset/RMRKTypedEquippableMock.md, docs/RMRK/extension/nestableAutoIndex/IRMRKNestableAutoIndex.md, docs/implementations/lazyMintErc20/RMRKNestableLazyMintErc20.md, docs/implementations/premint/RMRKNestableMultiAssetPreMint.md, docs/implementations/lazyMintErc20/RMRKEquippableLazyMintErc20.md, docs/implementations/lazyMintNative/RMRKNestableLazyMintNative.md, docs/implementations/premint/RMRKEquippablePreMintSoulbound.md, docs/implementations/premint/RMRKNestablePreMintSoulbound.md, docs/mocks/extensions/claimableChild/RMRKNestableClaimableChildMock.md, docs/implementations/abstract/RMRKAbstractNestableMultiAsset.md, docs/implementations/lazyMintNative/RMRKEquippableLazyMintNative.md, docs/mocks/extensions/soulbound/RMRKSoulboundNestableMultiAssetMock.md, docs/mocks/extensions/typedMultiAsset/RMRKNestableTypedMultiAssetMock.md, docs/implementations/lazyMintErc20/RMRKNestableLazyMintErc20Soulbound.md, docs/implementations/lazyMintErc20/RMRKNestableMultiAssetLazyMintErc20.md, docs/implementations/premint/RMRKNestableMultiAssetPreMintSoulbound.md, docs/implementations/lazyMintErc20/RMRKEquippableLazyMintErc20Soulbound.md, docs/implementations/lazyMintNative/RMRKNestableLazyMintNativeSoulbound.md, docs/implementations/lazyMintNative/RMRKNestableMultiAssetLazyMintNative.md, docs/RMRK/extension/nestableAutoIndex/RMRKNestableAutoIndex.md, docs/implementations/lazyMintNative/RMRKEquippableLazyMintNativeSoulbound.md, docs/implementations/lazyMintErc20/RMRKNestableMultiAssetLazyMintErc20Soulbound.md, docs/implementations/lazyMintNative/RMRKNestableMultiAssetLazyMintNativeSoulbound.md, test/bulkWriter.ts, docs/RMRK/nestable/IERC6059.md, contracts/RMRK/emotable/RMRKEmotesRepository.sol, contracts/RMRK/utils/RMRKNestableRenderUtils.sol, hardhat.config.ts, contracts/RMRK/nestable/RMRKNestable.sol, contracts/RMRK/equippable/RMRKMinifiedEquippable.sol, test/behavior/equippableSlots.ts

✨ Ask PR-Codex anything about this PR by commenting with /codex {your question}

@steven2308 steven2308 marked this pull request as ready for review September 19, 2023 19:30
Copy link
Contributor

@ThunderDeliverer ThunderDeliverer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Just some rewording suggestions in the CHANGELOG.

CHANGELOG.md Outdated Show resolved Hide resolved
CHANGELOG.md Outdated Show resolved Hide resolved
CHANGELOG.md Outdated Show resolved Hide resolved
CHANGELOG.md Outdated Show resolved Hide resolved
CHANGELOG.md Outdated Show resolved Hide resolved
CHANGELOG.md Outdated Show resolved Hide resolved
CHANGELOG.md Outdated Show resolved Hide resolved
@steven2308 steven2308 changed the base branch from master to dev September 20, 2023 17:05
@steven2308 steven2308 merged commit 99d6d47 into dev Sep 20, 2023
4 checks passed
@steven2308 steven2308 deleted the v2.1.0 branch January 5, 2024 17:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants