chore: update Position type document with correct coordinate order #3545
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tanlethanh
temporarily deployed
to
CI with Mapbox Tokens
GitHub Actions
Inactive
tanlethanh
temporarily deployed
to
CI with Mapbox Tokens
GitHub Actions
Inactive
tanlethanh
temporarily deployed
to
CI with Mapbox Tokens
GitHub Actions
Inactive
tanlethanh
temporarily deployed
to
CI with Mapbox Tokens
GitHub Actions
Inactive
tanlethanh
temporarily deployed
to
CI with Mapbox Tokens
GitHub Actions
Inactive
tanlethanh
temporarily deployed
to
CI with Mapbox Tokens
GitHub Actions
Inactive
tanlethanh
temporarily deployed
to
CI with Mapbox Tokens
GitHub Actions
Inactive
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
I revised the doc comment of type
Positionbecause it caused confusing for me when usingcoordinateprops ofMapMarker. The current comment indicatedlatitude and longitudeso I put the values as[latitude, longitude]which resulted in a crash in my Android app without any error. I was stuck for a while and later discovered that when running iOS app, it showed exceeded value range oflongitude. I hope this minor update might help Maps newbies save their time on this one.Checklist
CONTRIBUTING.md