[#129]: fix: replace not working for the GitHub builder

roadrunner-server · Jan 15, 2024 · f0b99f6 · f0b99f6
2 parents 8314e04 + f7f0391
commit f0b99f6
Show file tree

Hide file tree

Showing 3 changed files with 6 additions and 4 deletions.
diff --git a/github/pool.go b/github/pool.go
@@ -154,6 +154,7 @@ func (p *processor) run() {
 				modInfo.PseudoVersion = velox.ParseModuleInfo(modInfo.ModuleName, at.Time, commits[0].GetSHA()[:12])
 
 				if v.pluginCfg.Replace != "" {
+					modInfo.Replace = v.pluginCfg.Replace
 					p.log.Debug("[REPLACE REQUESTED]", zap.String("plugin", v.name), zap.String("path", v.pluginCfg.Replace))
 				}
 

diff --git a/github/repo.go b/github/repo.go
@@ -22,6 +22,7 @@ import (
 const (
 	rrOwner string = "roadrunner-server"
 	rrRepo  string = "roadrunner"
+	zipExt  string = ".zip"
 )
 
 /*
@@ -84,8 +85,8 @@ func (r *GHRepo) DownloadTemplate(tmp, version string) (string, error) { //nolin
 	name := path.Join(tmp, "roadrunner-server-"+version)
 	_ = os.RemoveAll(name)
 
-	r.log.Debug("[FLUSHING DATA ON THE DISK]", zap.String("path", name+".zip"))
-	f, err := os.Create(name + ".zip")
+	r.log.Debug("[FLUSHING DATA ON THE DISK]", zap.String("path", name+zipExt))
+	f, err := os.Create(name + zipExt)
 	if err != nil {
 		return "", err
 	}
@@ -101,7 +102,7 @@ func (r *GHRepo) DownloadTemplate(tmp, version string) (string, error) { //nolin
 
 	r.log.Debug("[SAVED]", zap.Int("bytes written", n))
 
-	rc, err := zip.OpenReader(name + ".zip")
+	rc, err := zip.OpenReader(name + zipExt)
 	if err != nil {
 		return "", err
 	}

diff --git a/velox_rr_v2023.toml b/velox_rr_v2023.toml
@@ -6,7 +6,7 @@ build_args = [
 ]
 
 [roadrunner]
-ref = "v2023.3.8"
+ref = "v2023.3.9"
 
 [github]
     [github.token]