Housekeeping #164
Closed
Housekeeping #164
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
resolve misc clippy warnings update to the latest baseview commit switch to once_cell instead of lazy_static
robbert-vdh
reviewed
Aug 18, 2024
| @@ -217,7 +217,7 @@ impl<'slice, 'sample> Block<'slice, 'sample> { | |||
| } | |||
|
|
|||
| /// Get a SIMD vector containing the channel data for a specific sample in this block. If `LANES | |||
| /// > channels.len()` then this will be padded with zeroes. If `LANES < channels.len()` then | |||
| /// \> channels.len()` then this will be padded with zeroes. If `LANES < channels.len()` then | |||
There was a problem hiding this comment.
You have a formatter doing something weird here too. May want to look into that!
There was a problem hiding this comment.
This was a clippy warning actually, something about using a special character so I escaped it manually. I'll double back on this
|
I'm not sure why you closed this btw |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a PR with some misc housekeeping, resolving clippy warnings, fixing the odd typo, and bumping baseview to the latest commit (it works on my machine™️)