add new ParamSliderStyle::FromMidPoint #187
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
magnetophon
added a commit
to magnetophon/vizia-plug
that referenced
this pull request
Dec 18, 2024
until robbert-vdh/nih-plug#187 is merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In cases like a modulation amount slider that has the same negative and positive range, you might want the default value to be non zero, so your user gets some modulation when they open your plugin for the first time.
At the same time, you want them to draw starting from the mid point, and not from the default value.
I have minimal comments, and I'm not sure about the name.
I wanted to get your feedback first.
PS: my editor wouldn't let me commit before I fixed the typo... ¯\_(ツ)_/¯