Use xmlDocGetRootElement when setting up namespaces. #28
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
April 28, 2013 09:11
This allows the caller to pass in an NSDictionary specifying the mapping from namespace prefix to namespace URL. Namespace prefixes specified in the given XPath will then be resolved against that mapping. This allows callers to find nodes using default namespaces, e.g. <element xmlns='<schema URL>'>...</element>. The caller must specify prefix=<schema URL> in namespaceMappings, and then can use prefix:element in the XPath. If namespaceMappings is nil, then the existing behavior is used (parsing the namespaces from the document node). This works in the situation where the namespaces are all named explicitly, and all on the root node, but not in general. This addresses upstream issue robbiehanson#19, the second half of issue robbiehanson#20.
The existing code uses doc->children, which is wrong in the case that the document has a doctype or PI nodes at the start. This fix is originally from upstream issue robbiehanson#20, by kgrigsby59. This changeset re-applies the fix on top of the nodesforxpath-namespacemappings branch (the two changes are in the same area of code).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The existing code uses doc->children, which is wrong in the case that the document has a doctype or PI nodes at the start.
This fix is originally from upstream issue #20, by kgrigsby59.
This changeset re-applies the fix on top of the nodesforxpath-namespacemappings branch (the two changes are in the same area of code).