Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add behavior message mappers #62

Merged
merged 15 commits into from
Oct 31, 2024
Merged

Add behavior message mappers #62

merged 15 commits into from
Oct 31, 2024

Conversation

ersaraujo
Copy link
Member

@ersaraujo ersaraujo commented Oct 26, 2024

Overview 👀

This PR add message mappers to behavior service and a generic use in behavior_processor

  • Add robotId message class
  • Add Output and Behavior message class
  • Add Motion (GoToPoint) message class

Notes 🗒️

The following implementations are pending:

  1. Other motion types messages [Feature Request] Message class for other Motion types in behavior service #65
  2. Planning message [Feature Request] Message class for planning in behavior service #64

@ersaraujo ersaraujo added enhancement New feature or request good first issue Good for newcomers help wanted Extra attention is needed labels Oct 26, 2024
@ersaraujo ersaraujo added this to the Integration Teste II milestone Oct 26, 2024
@ersaraujo ersaraujo self-assigned this Oct 26, 2024
@ersaraujo ersaraujo marked this pull request as ready for review October 26, 2024 16:47
@ersaraujo ersaraujo force-pushed the feat/behavior-message-mappers branch 2 times, most recently from 541dfd5 to 4c901b4 Compare October 26, 2024 18:44
@ersaraujo
Copy link
Member Author

Houve uma modificação da interface (#75), puxar a main.

Copy link

@MatheusPaixaoG MatheusPaixaoG left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Acho que seria interessante manter os construtores nos arquivos .cpp, mas funciona manter no .h também

@ersaraujo ersaraujo merged commit 52460bf into main Oct 31, 2024
1 check passed
@ersaraujo ersaraujo deleted the feat/behavior-message-mappers branch October 31, 2024 17:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request good first issue Good for newcomers help wanted Extra attention is needed
Development

Successfully merging this pull request may close these issues.

3 participants