HAL Logging Changes #104
Merged
HAL Logging Changes #104
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Artf 4809 upstream. Will need to be merged upstream before merging, as it requires a HAL Change. Also want to test and see what the error reporting looks like.
Also will now print exactly which method is the caller that threw. We can't get line numbers however. Also added a test for this.
Upstream was updated, so we have a valid HAL. So tests have been updated, and implementation has been tested in the Sim. Needs to be tested on a real RoboRIO before merging, although it should work.
Tested and Working
Current coverage is
|
|
This got merged upstream, and I was able to test it on the RoboRIO, so merging. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.