Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

'strong' attibutes replaced with 'copy' in block properties #138

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

protikhonov
Copy link

I've replaced "strong" attribute with "copy" in block properties.

"Note: You should specify copy as the property attribute, because a block needs to be copied to keep track of its captured state outside of the original scope. This isn’t something you need to worry about when using Automatic Reference Counting, as it will happen automatically, but it’s best practice for the property attribute to show the resultant behavior. For more information, see Blocks Programming Topics."

https://developer.apple.com/library/ios/documentation/Cocoa/Conceptual/ProgrammingWithObjectiveC/WorkingwithBlocks/WorkingwithBlocks.html

@Krivoblotsky
Copy link

+1. Can you please merge it asap?

@protikhonov
Copy link
Author

I don't have write access to this repository. So I'm waiting for merge too.

@fulldecent
Copy link

This is an easy enough change. I fully recommend to merge this.

@hpique
Copy link
Member

hpique commented Jan 3, 2016

This is not necessary, and I'm generally against as it fosters block memory management paranoia.

See: http://stackoverflow.com/questions/27152580/cocoa-blocks-as-strong-pointers-vs-copy

@Krivoblotsky @protikhonov @fulldecent Any particular reason why you want this merge?

balthisar added a commit to balthisar/RMStore that referenced this pull request Dec 24, 2019
…icts, etc., I'm adding these

manually, so the actual commits are not part of the git history, unfortunately. However this list
indicates the original PR number and the author.
- Add robotmedia#138 by @protikhonov.
- Add robotmedia#150 by @seantb.
- Add robotmedia#175 by @metasmile
everappz added a commit to everappz/RMStore that referenced this pull request Mar 24, 2024
'strong' attibutes replaced with 'copy' in block properties robotmedia#138
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants