Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added support for Carthage #157

Open
wants to merge 10 commits into
base: master
Choose a base branch
from
Open

Conversation

mluisbrown
Copy link

  • Added support for Carthage by including a Framework target.
  • Modified README.md to include Carthage info.

Note:

  1. Framework target does not include any receipt verification code as it's not a good idea to include it in a dynamic framework. Should always be statically linked, as should openssl, for security reasons.
  2. If/when this PR is merged, a new tag will need to be created as Carthage by default gets the latest tagged version of a repo, which would be the one without Carthage support until there is a new tag 😄

@derpoliuk
Copy link

Thank you for adding Carthage support, but I can't install it.

I added Carthfile with:
github "https://github.com/mluisbrown/RMStore"

and running carthage update. I'm getting this error:

*** Skipped building RMStore due to the error:
Dependency "RMStore" has no shared framework schemes

I'm searching info how to fix it, but maybe you did it already?

@mluisbrown
Copy link
Author

The problem is that Carthage will use the latest tagged version by default, which in this case won't include my changes, so you have to put:

github "https://github.com/mluisbrown/RMStore" "HEAD"

In you Cartfile to get the latest version.

@derpoliuk
Copy link

If/when this PR is merged, a new tag will need to be created as Carthage by default gets the latest tagged version of a repo, which would be the one without Carthage support until there is a new tag 😄

I missed that line, thank you a lot!

@mikemee
Copy link

mikemee commented Dec 31, 2015

+1 for this. @hpique, can I do anything to help get this merged?

As Carthage gets more and more adoption it would be nice to get this into the main repro rather than continuing to use the HEAD from @mluisbrown (thanks!).

# Conflicts:
#	README.md
#	RMStore.xcodeproj/project.pbxproj
#	RMStore.xcodeproj/xcshareddata/xcschemes/RMStore.xcscheme
#	RMStore.xcodeproj/xcshareddata/xcschemes/RMStoreDemo.xcscheme
#	RMStore.xcodeproj/xcshareddata/xcschemes/RMStoreExcludeKeychainTests.xcscheme
@z4r
Copy link

z4r commented May 27, 2016

Any news on this?

1 similar comment
@marbetschar
Copy link

Any news on this?

@marbetschar
Copy link

Sill can't use Carthage. @mluisbrown even your HEAD is no longer working :(

@mluisbrown
Copy link
Author

What's the problem you get @marbetschar using my HEAD? It seems to be working for me...

@marbetschar
Copy link

@mluisbrown I've added the following to my Cartfile

github "https://github.com/mluisbrown/RMStore" "HEAD"

And when I run carthage update it outputs the following:

*** Checking out RMStore at "e0e7389df28055aa453d4303b95cd16557cb7eac"
*** xcodebuild output can be found in /var/folders/ns/0h9r9v5908x4x67v5j9wvhvw0000gn/T/carthage-xcodebuild.0XwY4J.log
*** Skipped building RMStore due to the error:
Dependency "RMStore" has no shared framework schemes

If you believe this to be an error, please file an issue with the maintainers at https://github.com/mluisbrown/RMStore/issues/new

Apart from that it would be cool to have @hpique getting the Carthage support merged :(

@mluisbrown
Copy link
Author

@marbetschar ok, I synced my repo with changes from the upstream which is probably causing the problem. I have this in my Cartfile and it works fine:

github "mluisbrown/RMStore" "master"

I'm using Carthage 0.17.2

@mbcharbonneau
Copy link

👍 This is working well for me. I'd love to see it merged!

@rbaumbach
Copy link

Any update on when this will be merged?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants