-
Notifications
You must be signed in to change notification settings - Fork 450
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added support for Carthage #157
base: master
Are you sure you want to change the base?
Conversation
Thank you for adding Carthage support, but I can't install it. I added Carthfile with: and running
I'm searching info how to fix it, but maybe you did it already? |
The problem is that Carthage will use the latest tagged version by default, which in this case won't include my changes, so you have to put:
In you Cartfile to get the latest version. |
I missed that line, thank you a lot! |
+1 for this. @hpique, can I do anything to help get this merged? As Carthage gets more and more adoption it would be nice to get this into the main repro rather than continuing to use the HEAD from @mluisbrown (thanks!). |
# Conflicts: # README.md # RMStore.xcodeproj/project.pbxproj # RMStore.xcodeproj/xcshareddata/xcschemes/RMStore.xcscheme # RMStore.xcodeproj/xcshareddata/xcschemes/RMStoreDemo.xcscheme # RMStore.xcodeproj/xcshareddata/xcschemes/RMStoreExcludeKeychainTests.xcscheme
Any news on this? |
1 similar comment
Any news on this? |
Sill can't use Carthage. @mluisbrown even your HEAD is no longer working :( |
What's the problem you get @marbetschar using my HEAD? It seems to be working for me... |
@mluisbrown I've added the following to my Cartfile
And when I run
Apart from that it would be cool to have @hpique getting the Carthage support merged :( |
@marbetschar ok, I synced my repo with changes from the upstream which is probably causing the problem. I have this in my Cartfile and it works fine:
I'm using Carthage 0.17.2 |
👍 This is working well for me. I'd love to see it merged! |
Any update on when this will be merged? |
Note: