-
Notifications
You must be signed in to change notification settings - Fork 48
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add yarp-ros repo with Unstable branches and compile again against YARP master in Unstable branches #1547
Conversation
Build fails with:
The problem is that both |
Until the yarp-ros situation described in #1547 (comment) is fixed.
697ffb9
to
bfbb406
Compare
This was fixed by robotology/yarp-ros#19 . |
Ok, I removed the pin of yarp-3.9 branch in the Unstable branch, as this PR should now ready to merge. Unfortunately, this means that probably we will hit ~3 months backlog of regression due to the changes of YARP, some of which already hit @S-Dafarra . The first one is in Debian buster:
This was kind of expected. We already discussed about this with core and it basically means that we will stop supporting pc104 systems (see https://icub-tech-iit.github.io/documentation/icub_operating_systems/download/) when using YARP 3.10, and I think it was agreed this was ok (fyi @Nicogene @pattacini). |
We also have the same problem in Focal:
For what regards focal, we are not ready to drop 20.04 support (see #1439), so for patching focal probably we can install a newer CMake via either backports or kitware repo. |
Ok, now I see the error:
That I guess is what @S-Dafarra was reporting. |
Indeed. Related issues: |
Would it be possible to add also https://github.com/robotology/yarp-devices-ros? |
Sure, I did not realized that was a different repo as well. |
I heard from two developers in the last week that they had problems of compatibility due to this, let's try to wrap it up (also in view of a possible YARP 3.10.0 release). |
vcpkg build is not frequently use, I guess we can just add the right path in the CI script. |
Workaround added in 9b6fe9d . |
This was fixed in robotology/yarp@ac4b416, the merge yarp-3.9 --> master was broken and now it should work fine. |
New failure:
I think I already solved this in the past. |
This is a similar failure that currently is in I think that neither |
Thanks, I was actually confusing it with robotology/gazebo-yarp-plugins#690 that was for sure easier. |
Fix provided in robotology/yarp-devices-ros#3 . |
New fix robotology/gz-sim-yarp-plugins#217 (fyi @xela-95 can you quicky check the PR so we can unblock this one? Thanks!) |
Done! |
Thanks! |
Finally green! |
Actually not, still a Windows error after 1.5 h of CI:
|
The actual error is:
|
Argh, I tooth I had close this. |
Finally green! |
Fix #1536 .
Changes necessary to support modern YARP:
setup.bat
after the cmake invocation and before the build.This PR also adds a
ROBOTOLOGY_SUPERBUILD_BUILD_SEPARATE_YARP_ROS
CMake option, that isON
by default when used withROBOTOLOGY_PROJECT_TAGS
set toUnstable
, but that can be manually enable if users want to setYCM_EP_DEVEL_MODE_YARP
toON
and manually switch to useYARP
master and the future YARP 3.10.fyi @SimoneMic @GiulioRomualdi @S-Dafarra