Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change color of Check button based on autocheck status #329

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

x-sheep
Copy link
Collaborator

@x-sheep x-sheep commented Nov 29, 2022

Part of #328

This will change the Check button to display one of three colors, depending on if the Answer Check is on Guarded, Auto or Disabled. The color considers the effective setting, meaning that a puzzle without support for Guarded will not display the Guarded colors. Edit mode will always show the Disabled colors.

I'm not too attached to any of the colors here, so feel free to change them around.

@vercel
Copy link

vercel bot commented Nov 29, 2022

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated
pzprjs ✅ Ready (Inspect) Visit Preview Nov 29, 2022 at 3:25PM (UTC)

@robx
Copy link
Owner

robx commented Nov 29, 2022

I'm not sure this is much of an improvement as is, seems it might be worthwhile iterating on the change a bit.

I was imagining something a bit more dynamic, taking into account the state of the puzzle. E.g.:

  • with manual check, the button is always a blue "Check" as currently
  • with unguarded autocheck, the button is a red "Show errors" while the puzzle is unsolved, and a disabled "Complete" when it's solved
  • with guarded autocheck, the button is a faint red "Incomplete" while the checker fails in the autocheck guard, and behaves like unguarded autocheck when the completeness check passes

(Red "Show errors" seems a bit too extreme, but something along those lines would make it more clear what's actually going on.)

@x-sheep
Copy link
Collaborator Author

x-sheep commented Nov 29, 2022

  • with guarded autocheck, the button is a faint red "Incomplete" while the checker fails in the autocheck guard, and behaves like unguarded autocheck when the completeness check passes

Wouldn't it make more sense for the Check button to show which cells need to be determined? If we're just going off dynamic button labels, clicking a button labeled "Incomplete" can still show a "Completed" popup if there are no actual errors.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants