Skip to content

Commit

Permalink
hashes: Hide both macros
Browse files Browse the repository at this point in the history
We have two macro definitions feature gated on `serde`. At some stage we
added the `doc(hidden)` attribute to one of them but forgot to add it to
the other. This technically makes our features non-additive. This macro
is "internal" so its unlikely that this is being used in the wild.

Add `doc(hidden)` to the `serde_impl` macro that is missing it.

Found by `cargo semver-checks` after recent upgrade to 0.38
  • Loading branch information
tcharding committed Dec 28, 2024
1 parent 39dedf4 commit ed387e5
Showing 1 changed file with 1 addition and 0 deletions.
1 change: 1 addition & 0 deletions hashes/src/macros.rs
Original file line number Diff line number Diff line change
Expand Up @@ -533,6 +533,7 @@ macro_rules! serde_impl(
));

/// Does an "empty" serde implementation for the configuration without serde feature.
#[doc(hidden)]
#[macro_export]
#[cfg(not(feature = "serde"))]
macro_rules! serde_impl(
Expand Down

0 comments on commit ed387e5

Please sign in to comment.