Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Noissue multiarch build #7

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Noissue multiarch build #7

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
8725456
feat(docker): Use buildx to generate multiplatform builds
rodneyosodo May 11, 2024
9ddba8b
Update Makefile
rodneyosodo May 12, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
27 changes: 15 additions & 12 deletions .github/workflows/build.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,10 @@ on:
push:
branches:
- main

pull_request:
branches:
- main

jobs:
build-and-push:
name: Build and Push
Expand All @@ -23,17 +26,17 @@ jobs:
go-version: 1.21.x
cache-dependency-path: "go.sum"

- name: Run tests
run: |
make test

- name: Upload coverage
uses: codecov/codecov-action@v4
with:
token: ${{ secrets.CODECOV }}
directory: ./coverage/
name: codecov-umbrella
verbose: true
# - name: Run tests
# run: |
# make test

# - name: Upload coverage
# uses: codecov/codecov-action@v4
# with:
# token: ${{ secrets.CODECOV }}
# directory: ./coverage/
# name: codecov-umbrella
# verbose: true

- name: Set up Docker Build
uses: docker/setup-buildx-action@v3
Expand Down
5 changes: 3 additions & 2 deletions Makefile
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
# Copyright (c) Abstract Machines
# SPDX-License-Identifier: Apache-2.0

MG_DOCKER_IMAGE_NAME_PREFIX ?= magistrala
MG_DOCKER_IMAGE_NAME_PREFIX ?= rodneydav
BUILD_DIR = build
SERVICES = auth users things http coap ws lora influxdb-writer influxdb-reader mongodb-writer \
mongodb-reader cassandra-writer cassandra-reader postgres-writer postgres-reader timescale-writer timescale-reader cli \
Expand Down Expand Up @@ -48,7 +48,8 @@ endef
define make_docker
$(eval svc=$(subst docker_,,$(1)))

docker build \
docker buildx build \
--platform linux/386,linux/amd64,linux/arm/v7,linux/arm64 \
--no-cache \
--build-arg SVC=$(svc) \
--build-arg GOARCH=$(GOARCH) \
Expand Down
Loading