Add unix socket support #67
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
actually there is a bug here - when a client connects its address is printed from uninitialized memory |
|
Addresses not known by inet_ntop will be logged as blank. In the case of UNIX sockets, the client address is almost certain to be a randomly generated byte string so there isn't much the user can do with it. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This patch allows microsocks to listen on a UNIX domain socket (AF_UNIX).
Unix client addresses will be truncated in client->addr, but we don't care because -1 is not supported in this mode.
Disappointingly there's nothing you can pass to getaddrinfo to make it return a UNIX socket address, so a whole new function is needed.