Print timestamps in logs #70
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rofl0r
reviewed
Dec 21, 2023
| #define LOGTS() { \ | ||
| char t[20] = {}; struct tm tm_buf; time_t secs = time(NULL); \ | ||
| strftime(t, sizeof(t), "[%m-%d %T] ", localtime_r(&secs, &tm_buf)); \ | ||
| fputs(t, stderr); \ |
There was a problem hiding this comment.
you should use dprintf here too as buffered io isn't threadsafe - at least on glibc. mixing buffered and non-buffered makes the problem even worse.
There was a problem hiding this comment.
also, LOGTS should be a function to prevent all the code from be expanded at every callsite.
There was a problem hiding this comment.
Please use %Y-%m-%d %T for less ambiguity too.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I've been using microsocks for a week and the only issue bothering me is the lack of timestamped outputs.
Some additional notes
I've only added timestamps to the
dologmacro as this is what I needed the most. Functions callingperrorare still not timestamped.