remove unused args, cleanup #43
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Removed unused args
Styling changes for consistency (mostly white space: indentation,
if()vsif (), trailing spaces, etc)I tried to keep this light, there are other changes to content.js I considered:
replacing the var declarations with block scoped (let and const) declarations (I wasn't sure if this was intentional to support chrome versions <40)
removing variable assignment from while conditions in removeHighlight (line 98), I appreciate conciseness but I think you're losing readability here
I think how you're iterating through nodes in selectNode (line 131) could probably be improved (at least to lower the line length) but I think the readability is ok here so maybe this is moot
your thoughts?