Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove the ropm step, devs just need to do this manually #310

Merged
merged 3 commits into from
Jan 30, 2025
Merged

Remove the ropm step, devs just need to do this manually #310

merged 3 commits into from
Jan 30, 2025
+7 −73

Conversation

TwitchBronBron
Copy link
Member

Removes the ropm copy step in the package.json postinstall, it was causing issues when installing from npm.

Maintainers of rooibos will need to run ropm copy themselves for now, but that's not a big deal...

@TwitchBronBron TwitchBronBron added the create-package create a temporary npm package on every commit label Jan 30, 2025
@rokucommunity-bot
Copy link

Hey there! I just built a new temporary npm package based on 104f63a. You can download it here or install it by running the following command:

npm install https://github.com/rokucommunity/rooibos/releases/download/v0.0.0-packages/rooibos-roku-5.15.0-fix-ropm-postinstall.20250130170300.tgz

@rokucommunity-bot
Copy link

Hey there! I just built a new temporary npm package based on 3526757. You can download it here or install it by running the following command:

npm install https://github.com/rokucommunity/rooibos/releases/download/v0.0.0-packages/rooibos-roku-5.15.0-fix-ropm-postinstall.20250130183453.tgz

@TwitchBronBron TwitchBronBron merged commit 339fa7d into master Jan 30, 2025
4 checks passed
@TwitchBronBron TwitchBronBron deleted the fix-ropm-postinstall branch January 30, 2025 19:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@luis-j-soares luis-j-soares luis-j-soares approved these changes

Assignees
No one assigned
Labels
create-package create a temporary npm package on every commit
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@TwitchBronBron @luis-j-soares