Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Device disconnect support and other improvements #548

Conversation

triwav
Copy link
Collaborator

@triwav triwav commented Feb 29, 2024

add support for disconnecting from device in webview panels, avoid issues with deploying due to screenshot capture happening at same time, add support for copying node info response in scenegraph inspector detail view.

Screenshot of the device view:

image

Copy link
Member

@TwitchBronBron TwitchBronBron left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Everything looks good. One suggestion would be to re-enable the device view if the debug session crashes for some reason. There might be a "vscode.debug.onDidStopDebugSession" event? Not a blocker though.

@TwitchBronBron TwitchBronBron merged commit 5232b07 into master Mar 1, 2024
5 checks passed
@TwitchBronBron TwitchBronBron deleted the add_device_disconnect_and_ability_to_copy_node_info_response branch March 1, 2024 18:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants