-
Notifications
You must be signed in to change notification settings - Fork 41
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Device disconnect support and other improvements #548
Merged
TwitchBronBron
merged 18 commits into
master
from
add_device_disconnect_and_ability_to_copy_node_info_response
Mar 1, 2024
Merged
Device disconnect support and other improvements #548
TwitchBronBron
merged 18 commits into
master
from
add_device_disconnect_and_ability_to_copy_node_info_response
Mar 1, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…le for new panels
… of https://github.com/rokucommunity/vscode-brightscript-language into add_roku_app_overlays_panel_and_roku_file_system_panel
…sues with deploying due to screenshot capture happening at same time, add support for copying node info response in scenegraph inspector detail view
…node_info_response
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Everything looks good. One suggestion would be to re-enable the device view if the debug session crashes for some reason. There might be a "vscode.debug.onDidStopDebugSession" event? Not a blocker though.
TwitchBronBron
approved these changes
Mar 1, 2024
TwitchBronBron
deleted the
add_device_disconnect_and_ability_to_copy_node_info_response
branch
March 1, 2024 18:50
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
add support for disconnecting from device in webview panels, avoid issues with deploying due to screenshot capture happening at same time, add support for copying node info response in scenegraph inspector detail view.
Screenshot of the device view: