Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Task/new remote commands #605

Merged
merged 4 commits into from
Nov 22, 2024
Merged

Task/new remote commands #605

merged 4 commits into from
Nov 22, 2024

Conversation

chrisdp
Copy link
Collaborator

@chrisdp chrisdp commented Nov 22, 2024

Added the following new commands:

  • extension.brightscript.setVolume: Set a target volume level by repeatedly pressing VolumeDown followed by VolumeUp buttons on the Roku remote
  • extension.brightscript.pressBlue: Press the Blue button on the Roku remote
  • extension.brightscript.pressGreen: Press the Green button on the Roku remote
  • extension.brightscript.pressRed: Press the Red button on the Roku remote
  • extension.brightscript.pressYellow: Press the Yellow button on the Roku remote
  • extension.brightscript.pressExit: Press the Exit button on the Roku remote

Fixed the following commands:

  • extension.brightscript.pressVolumeUp: This was sending the wrong value to the device resulting in an error and failing to execute

package.json Outdated Show resolved Hide resolved
Co-authored-by: Bronley Plumb <[email protected]>
Copy link
Member

@TwitchBronBron TwitchBronBron left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good other than my one suggestion.

@chrisdp chrisdp enabled auto-merge (squash) November 22, 2024 20:35
@chrisdp chrisdp merged commit be76ac4 into master Nov 22, 2024
4 checks passed
@chrisdp chrisdp deleted the task/new-remote-commands branch November 22, 2024 20:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants